Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] [e2e-tests]Should remove and restore labeler only from workers #9274

Closed
wants to merge 1 commit into from
Closed

[release-0.58] [e2e-tests]Should remove and restore labeler only from workers #9274

wants to merge 1 commit into from

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #9215

/assign Barakmor1

NONE

Should remove and restore labeller only from workers Currently in som…
c4044a7 
…e tests we are waiting for the node labeller to be resumed in any nodes including unschedulable nodes and that will not work because master shouldn't be labeled by node labeller.

Signed-off-by: bmordeha <bmodeha@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Feb 19, 2023
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 19, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xpivarc for approval by writing /assign @xpivarc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iholder101
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2023
@enp0s3
Copy link
Contributor

enp0s3 commented Feb 19, 2023

@Barakmor1 Hey, can you please check the CI lanes logs? it looks like make generate ends up with some changes

@Barakmor1
Copy link
Member

/retest-required

@Barakmor1
Copy link
Member

@enp0s3 sure thanks for the note

@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-check-tests-for-flakes c4044a7 link false /test pull-kubevirt-check-tests-for-flakes-0.58
pull-kubevirt-goveralls c4044a7 link false /test pull-kubevirt-goveralls-0.58
pull-kubevirt-e2e-kind-1.23-vgpu-nonroot c4044a7 link true /test pull-kubevirt-e2e-kind-1.23-vgpu-nonroot-0.58
pull-kubevirt-e2e-kind-1.22-sriov-nonroot c4044a7 link true /test pull-kubevirt-e2e-kind-1.22-sriov-nonroot-0.58
pull-kubevirt-e2e-k8s-1.23-sig-network c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-network-0.58
pull-kubevirt-e2e-k8s-1.23-sig-storage c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-storage-0.58
pull-kubevirt-e2e-k8s-1.22-sig-compute c4044a7 link true /test pull-kubevirt-e2e-k8s-1.22-sig-compute-0.58
pull-kubevirt-e2e-k8s-1.24-sig-storage c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-storage-0.58
pull-kubevirt-e2e-kind-1.23-vgpu c4044a7 link true /test pull-kubevirt-e2e-kind-1.23-vgpu-0.58
pull-kubevirt-e2e-k8s-1.23-sig-network-nonroot c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-network-nonroot-0.58
pull-kubevirt-e2e-k8s-1.24-sig-compute-migrations-nonroot c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-compute-migrations-nonroot-0.58
pull-kubevirt-e2e-k8s-1.23-operator c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-operator-0.58
pull-kubevirt-e2e-k8s-1.24-sig-compute-migrations c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-compute-migrations-0.58
pull-kubevirt-e2e-k8s-1.24-operator c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-operator-0.58
pull-kubevirt-e2e-k8s-1.23-sig-storage-nonroot c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-storage-nonroot-0.58
pull-kubevirt-e2e-k8s-1.24-sig-storage-dv-gc c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-storage-dv-gc-0.58
pull-kubevirt-e2e-k8s-1.23-operator-nonroot c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-operator-nonroot-0.58
pull-kubevirt-e2e-k8s-1.22-operator c4044a7 link true /test pull-kubevirt-e2e-k8s-1.22-operator-0.58
pull-kubevirt-e2e-k8s-1.22-sig-network c4044a7 link true /test pull-kubevirt-e2e-k8s-1.22-sig-network-0.58
pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations-0.58
pull-kubevirt-e2e-k8s-1.24-sig-network c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-network-0.58
pull-kubevirt-e2e-k8s-1.24-sig-compute c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-sig-compute-0.58
pull-kubevirt-e2e-k8s-1.22-sig-storage c4044a7 link true /test pull-kubevirt-e2e-k8s-1.22-sig-storage-0.58
pull-kubevirt-e2e-windows2016 c4044a7 link true /test pull-kubevirt-e2e-windows2016-0.58
pull-kubevirt-e2e-k8s-1.24-ipv6-sig-network c4044a7 link true /test pull-kubevirt-e2e-k8s-1.24-ipv6-sig-network-0.58
pull-kubevirt-e2e-k8s-1.23-sig-compute-nonroot c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-compute-nonroot-0.58
pull-kubevirt-e2e-k8s-1.23-sig-compute c4044a7 link true /test pull-kubevirt-e2e-k8s-1.23-sig-compute-0.58
pull-kubevirt-generate c4044a7 link true /test pull-kubevirt-generate-0.58
pull-kubevirt-build c4044a7 link true /test pull-kubevirt-build-0.58
pull-kubevirt-build-arm64 c4044a7 link true /test pull-kubevirt-build-arm64-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Barakmor1
Copy link
Member

/close
@enp0s3 created a new PR :
#9278

@kubevirt-bot
Copy link
Contributor Author

@Barakmor1: Closed this PR.

In response to this:

/close
@enp0s3 created a new PR :
#9278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees

@iholder101 iholder101

@Barakmor1 Barakmor1

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubevirt-bot @iholder101 @enp0s3 @Barakmor1