Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] Set mem/cpu request and limits on hotplug attachment pod container to 1 to 1 ratio #9353

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[release-0.58] Set mem/cpu request and limits on hotplug attachment pod container to 1 to 1 ratio #9353

merged 2 commits into from
Mar 3, 2023

Conversation

awels
Copy link
Member

@awels awels commented Mar 2, 2023

What this PR does / why we need it:
Manual backport of #9312 needed to adjust the functional test to use older mechanisms.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/L labels Mar 2, 2023
@mhenriks
Copy link
Member

mhenriks commented Mar 2, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
kubevirt-bot and others added 2 commits March 2, 2023 12:50
@kubevirt-bot @awels
Merge pull request kubevirt#9312 from awels/set_hotplug_cpu_mem_ratio…
2be809e 
…_to_1

Set mem/cpu request and limits on hotplug attachment pod container to 1 to 1 ratio

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
Fix test for backport
6d21840 
Signed-off-by: Alexander Wels <awels@redhat.com>
@awels awels force-pushed the set_hotplug_cpu_mem_ratio_to_1_058 branch from 3abe40a to 6d21840 Compare March 2, 2023 18:50
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 2, 2023
@awels
Copy link
Member Author

awels commented Mar 2, 2023

/test pull-kubevirt-goveralls-0.58

@awels
Copy link
Member Author

awels commented Mar 2, 2023

/test pull-kubevirt-e2e-kind-1.23-vgpu-0.58

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Mar 2, 2023 •
edited

@awels: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-goveralls 6d21840 link false /test pull-kubevirt-goveralls-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alromeros
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@kubevirt-bot kubevirt-bot merged commit 7603524 into kubevirt:release-0.58 Mar 3, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicefr alicefr Awaiting requested review from alicefr

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

Assignees

@mhenriks mhenriks

@alromeros alromeros

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awels @mhenriks @kubevirt-bot @alromeros