Bump alpine to 3.19

[akalenyu]

What this PR does / why we need it:
Turns out the cloud-init-local service is now vital for cloud-init to work on Alpine:
https://leo.leung.xyz/wiki/Cloud-init
https://gitlab.com/redhat/centos-stream/rpms/cloud-init/-/blob/020655f489ca26b5830de8423354a14ccd0552db/cloud-init.spec#L138
I've double checked cloud-init breaks when I remove it.
(quay.io/akalenyu/alpine-cloud-init:3.19-broken vs quay.io/akalenyu/alpine-cloud-init:3.19)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

[andreabolognani]

@akalenyu thank you again for your amazing work here! You really got us out of the rut we were stuck in.

I've tested the updated image and the NoCloud volume is finally being taken into consideration. However, we also need

diff --git a/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh b/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
index f88e0265..4e3b7656 100755
--- a/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
+++ b/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
@@ -25,4 +25,5 @@ rc-update add cloud-init default
 rc-update add cloud-init-local default
 rc-update add cloud-config default
 rc-update add cloud-final default
+rc-update add networking default
 rc-update add sshd default

otherwise the network interfaces will not be brought up.

[andreabolognani]

Can you please fix the alignment while you're at it? It really bugs me that this line doesn't sit flush with the surrounding ones O:-)

[akalenyu]

sure, done

[akalenyu]

@akalenyu thank you again for your amazing work here! You really got us out of the rut we were stuck in.

I've tested the updated image and the NoCloud volume is finally being taken into consideration. However, we also need

diff --git a/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh b/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
index f88e0265..4e3b7656 100755
--- a/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
+++ b/cluster-provision/images/vm-image-builder/alpine-cloud-init/configure.sh
@@ -25,4 +25,5 @@ rc-update add cloud-init default
 rc-update add cloud-init-local default
 rc-update add cloud-config default
 rc-update add cloud-final default
+rc-update add networking default
 rc-update add sshd default

otherwise the network interfaces will not be brought up.

thanks, done
wonder what changed now, that made us have to do it explicitly

[kubevirt-bot]

@akalenyu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-up-kind-1.27-vgpu	eb91f85	link	false	/test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[andreabolognani]

/lgtm

[andreabolognani]

Can this be moved forward? My PR that needs it (kubevirt/kubevirt#11256) is waiting for some changes on the CentOS Stream side, but we could do the bump to Alpine 3.19 in KubeVirt separately in the meantime, sort of get ahead of the game in a sense...

[akalenyu]

Can this be moved forward? My PR that needs it (kubevirt/kubevirt#11256) is waiting for some changes on the CentOS Stream side, but we could do the bump to Alpine 3.19 in KubeVirt separately in the meantime, sort of get ahead of the game in a sense...

/cc @dhiller

[dhiller]

/approve

Thanks @akalenyu !

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-provision/images/vm-image-builder/OWNERS [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhiller]

/test check-provision-k8s-1.30

[dhiller]

^^ looked like a hiccup

[kubevirt-commenter-bot]

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[andreabolognani]

@akalenyu @dhiller I don't see an updated image at https://quay.io/repository/kubevirtci/alpine-with-test-tooling-container-disk?tab=tags, does a job need to be kicked off manually or something?

[akalenyu]

@akalenyu @dhiller I don't see an updated image at https://quay.io/repository/kubevirtci/alpine-with-test-tooling-container-disk?tab=tags, does a job need to be kicked off manually or something?

There should be a tag containing this commit in
https://github.com/kubevirt/kubevirtci/tags
(which would also handle publishing the alpine img, IIUC)
But for some reason quite some time passed and this didn't happen

[andreabolognani]

Still no image AFAICT...

[dhiller]

Still no image AFAICT...

Hey @akalenyu @andreabolognani image should be there now - latest image tag is 2404181910-1c58677

[andreabolognani]

@dhiller yup, it's there now. Thanks a lot! For future reference, how did you make it happen? Did some automation need to be fixed, some job need to be kicked off manually, something else...