Add AAQ Operator as an optional cluster addon #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAQ Operator will be disabled by default To install AAQ set KUBEVIRT_DEPLOY_AAQ to true to use custom version set KUBEVIRT_CUSTOM_AAQ_VERSION with the desired version. Signed-off-by: bmordeha <bmordeha@redhat.com>
kubevirt-bot
added
dco-signoff: yes
|
/cc @dhiller @brianmcarey @vladikr PTAL |
|
@Barakmor1: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dhiller
approved these changes
Apr 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Apr 23, 2024
[8f203b9 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1181) [5d854e0 centos9: Add --numa support to vm.sh](kubevirt/kubevirtci#1174) [73b90a3 Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#1175) [1c58677 Remove NoSchedule taints for control-planes as well as masters](kubevirt/kubevirtci#1173) [9d50baf Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1168) [ef69592 Bump alpine to 3.19](kubevirt/kubevirtci#1167) [4c6d7c7 Add AAQ Operator as an optional cluster addon](kubevirt/kubevirtci#1170) [d69cd4e Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1166) [62457f2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1162) [85d8a72 centos: Update centos stream base to 20240318.0](kubevirt/kubevirtci#1161) [970d172 Bump github.com/docker/docker in /cluster-provision/gocli](kubevirt/kubevirtci#1159) ```release-note NONE ``` Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAQ Operator will be disabled by default
To install AAQ set KUBEVIRT_DEPLOY_AAQ to true before
make cluster-upto use custom version set KUBEVIRT_CUSTOM_AAQ_VERSION with the desired version.
What this PR does / why we need it:
AAQ is operator used to solve multi-tenancy issue with kubevirt in a kubernetes native way.
Adding this addon will help future development of kubevirt policy that define how resource
counting should be done with virtual machine workloads.
Development of AAQ will allow replacing workarounds used by some projects using Kubevirt in a multi tenant environments for instance:
https://docs.harvesterhci.io/v1.2/rancher/resource-quota/#automatic-adjustment-of-resourcequota-during-migration
For more details about the multi-tenancy issue with kubevirt please see:
https://groups.google.com/g/kubevirt-dev/c/lZKEdyNqwsc
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: