Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubevirt_mg] cover --since and --since-time options #50856

Merged
merged 1 commit into from
Apr 21, 2024
Merged

[kubevirt_mg] cover --since and --since-time options #50856

merged 1 commit into from
Apr 21, 2024

Conversation

tiraboschi
Copy link
Contributor

Check also must-gather archives generated
using --since and --since-time options.
Bump to OCP 4.16 since the two new options
are available only there.

see: https://issues.redhat.com/browse/OCPSTRAT-1040

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@tiraboschi
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/retest

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

nunnatsa
nunnatsa approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nunnatsa
Copy link
Contributor

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
[kubevirt_mg] cover --since and --since-time options
e834b6f 
Check also must-gather archives generated
using --since and --since-time options.
Bump to OCP 4.16 since the two new options
are available only there.

see: https://issues.redhat.com/browse/OCPSTRAT-1040

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tiraboschi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-kubevirt-must-gather-main-images kubevirt/must-gather presubmit Ci-operator config changed
pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-azure kubevirt/must-gather presubmit Ci-operator config changed
pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp kubevirt/must-gather presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-must-gather-main-kubevirt-must-gather-e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

nunnatsa
nunnatsa approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nunnatsa
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

@tiraboschi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5e2ffc5 into openshift:master Apr 21, 2024
17 checks passed
@nunnatsa nunnatsa mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@tiraboschi @openshift-ci-robot @nunnatsa