Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new lane for running periodic realtime perf tests #1622

Merged

Conversation

jordigilh
Copy link
Contributor

Adds a new lane for running the realtime performance tests. These tests capture the maximum CPU latency when running a VM in realtime and compare it against a given latency threshold. The test will pass if the maximum latency is below the given threshold.

@fgimenez @vladikr @acardace @pkliczewski @rmohr @dhiller

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Sep 25, 2021
@jordigilh jordigilh force-pushed the add_periodic_performance_realtime_lane branch 5 times, most recently from 1b4bf2f to 1952867 Compare September 26, 2021 15:57
@jordigilh jordigilh force-pushed the add_periodic_performance_realtime_lane branch from 1952867 to e118675 Compare September 27, 2021 13:21
Signed-off-by: Jordi Gil <jgil@redhat.com>
@jordigilh jordigilh force-pushed the add_periodic_performance_realtime_lane branch from e118675 to 7d910a9 Compare October 4, 2021 14:03
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Holding this to wait for the required PR to go in.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@dhiller
Copy link
Contributor

dhiller commented Oct 7, 2021

@dhiller
Copy link
Contributor

dhiller commented Oct 7, 2021

@jordigilh I've triggered the lane, results will come up here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.22-sig-performance-realtime/1446074801864052736

Let's see how it goes.

It failed due to pulling the image: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.22-sig-performance-realtime/1446074801864052736#1:build-log.txt%3A757

However, that is unrelated to the test lane itself, so I'll remove the hold

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2021
@kubevirt-bot kubevirt-bot merged commit ad0ee9e into kubevirt:main Oct 7, 2021
@kubevirt-bot
Copy link
Contributor

@jordigilh: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml

In response to this:

Adds a new lane for running the realtime performance tests. These tests capture the maximum CPU latency when running a VM in realtime and compare it against a given latency threshold. The test will pass if the maximum latency is below the given threshold.

@fgimenez @vladikr @acardace @pkliczewski @rmohr @dhiller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants