Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jschintag to kubevirt members #3328

Merged
merged 1 commit into from Apr 9, 2024

Conversation

jschintag
Copy link
Contributor

@jschintag jschintag commented Mar 27, 2024

GitHub Username

@jschintag

Requirements

(https://github.com/kubevirt/community#socializing)

Sponsors

List of contributions to the KubeVirt project

  • PRs reviewed and/or authored
  • Issues responded to

Reason for joining

I am currently working on enabling kubevirt to run on the s390x architecture. For that reason i would like to join the kubevirt org to be able to better maintain the s390x support, as well as general multi-arch support.

Important

After this pull request has been merged, an invitation to the KubeVirt GitHub organization will be automatically sent to the new member. The new member needs to accept the invitation to receive member status.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 27, 2024
@kubevirt-bot
Copy link
Contributor

Hi @jschintag. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jschintag jschintag changed the title Add jschintag to kubevirt members WIP: Add jschintag to kubevirt members Mar 27, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@brianmcarey
Copy link
Member

/cc

@dhiller
Copy link
Contributor

dhiller commented Mar 27, 2024

/cc

Would happily sponsor you @jschintag

FYI @fabiand

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold for some others to chime in

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@jschintag jschintag changed the title WIP: Add jschintag to kubevirt members Add jschintag to kubevirt members Apr 5, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024
@jschintag
Copy link
Contributor Author

@dhiller Thank you for sponsoring me, i have added you as a sponsor. I hope you have (had when you read this) a nice vacation.

@victortoso
Copy link
Member

victortoso commented Apr 5, 2024

+1

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@dhiller
Copy link
Contributor

dhiller commented Apr 8, 2024

/unhold

@jschintag welcome to the KubeVirt community! 🎉

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@jschintag
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Contributor

@jschintag: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 92c7ce0 into kubevirt:main Apr 9, 2024
5 checks passed
@dhiller
Copy link
Contributor

dhiller commented Apr 9, 2024

/retest

You will be allowed to execute this (and other) prow commands after you've accepted the invitation joining the KubeVirt org :)

Barakmor1 pushed a commit to Barakmor1/project-infra that referenced this pull request Apr 24, 2024
Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants