-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console proxy and tests: Stabilize functional tests #527
fix: console proxy and tests: Stabilize functional tests #527
Conversation
Functions RevertToOriginalSspCr() now wait until SSP is deployed before returning. This is useful, because reverting SSP may change TLS policy, which causes the pod to crash, and it may be some time before it is running again. If in the meantime, another test tries to update the SSP, it will fail, because the webhook cannot be reached. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Sounds valid at first glance, just waiting on CI. |
/retest |
1 similar comment
/retest |
I need to fix another race. /hold |
When the annotation "ssp.kubevirt.io/vm-console-proxy-enabled" is removed from SSP, the operator removes resources for vm-console-proxy, but previously it did not wait until they were removed. With this chnange, the SSP will not be in "Deployed" state until the resources are removed. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
2f310ab
to
b865719
Compare
/hold cancel |
/retest |
2 similar comments
/retest |
/retest |
It may take a moment until the vm-console-proxy is reachable using the Route. This commit wraps the request in an Eventually() loop. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This PR contains 2 changes to make functional tests less flaky:
Functions
RevertToOriginalSspCr()
now wait until SSP is deployed before returning.This is useful, because reverting SSP may change TLS policy, which causes the pod to crash, and it may be some time before it is running again. If in the meantime, another test tries to update the SSP, it will fail, because the webhook cannot be reached.
When the annotation
ssp.kubevirt.io/vm-console-proxy-enabled
is removed from SSP CR, the operator waits for resources to be removed before setting thestatus.phase
toDeployed
.Release note: