This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Fix alter_time format when deleting old data (bsc#1112967) #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
suggested changes
Oct 29, 2018
app/models/salt_event.rb
Outdated
| ") | ||
| [:events, :returns].each do |table| | ||
| ActiveRecord::Base.connection.execute(" | ||
| delete from `salt_#{table}` where alter_time < #{date.to_i}; | ||
| delete from `salt_#{table}` where unix_timestamp(alter_time) < #{date.to_i}; |
There was a problem hiding this comment.
I think we should rethink this a bit more, because with this we could effectively delete events that weren't processed at all (processed_at IS NULL)
|
I see I am a reviewer. I will wait for ereslibre approval and then I will give you my approval . |
mjura
force-pushed
the
alter_time
branch
2 times, most recently
from
06944b1
to
bfbd99c
Compare
|
I've updated also brakeman ignore config file |
ereslibre
suggested changes
Oct 30, 2018
app/models/salt_event.rb
Outdated
| delete from `salt_#{table}` where alter_time < #{date.to_i}; | ||
| ActiveRecord::Base.connection.execute(" | ||
| delete from `salt_events` where unix_timestamp(alter_time) < #{date.to_i} | ||
| and processed_at is NULL; |
There was a problem hiding this comment.
This needs to be processed_at is not null; so we are sure that we are cleaning events that have been processed (their processed_at column is not NULL).
ereslibre
approved these changes
Oct 30, 2018
MaximilianMeister
approved these changes
Oct 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.