Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown for limit #160

Closed
ryasmi opened this issue Sep 7, 2018 · 5 comments
Closed

Error thrown for limit #160

ryasmi opened this issue Sep 7, 2018 · 5 comments

Comments

@ryasmi
Copy link

ryasmi commented Sep 7, 2018 •
edited
Loading

Hey, I think there might be some issue with your type checking on command arguments. I'm seeing the error below in our CircleCI builds for v0.6.23.

npm run duplication

> @learninglocker/xapi-validation@0.0.0-development duplication /root/repo
> jscpd --limit 1

ERROR: --limit expects a number. Use `jscpd --limit=NUMBER`

LearningLocker/xapi-validation#63
@kucherenko
Copy link
Owner

Thank you for reporting, will fix it soon, for now I can suggest use previous version 0.6.22 or jscpd@1.0.0-alpha.2, also you can try to use limit=1.0

ryasmi added a commit to LearningLocker/xapi-validation that referenced this issue Sep 10, 2018
@ryasmi
ci: Attempts fix described in kucherenko/jscpd#160.
858d8a4
ryasmi pushed a commit to LearningLocker/xapi-validation that referenced this issue Sep 10, 2018
@renovate @ryasmi
chore(deps): update dependency jscpd to v0.6.23 (#63)
9f05dfd 
* chore(deps): update dependency jscpd to v0.6.23

* ci: Adds limit to script to fix build.

* ci(jscpd): Removes limit from manifest to prefer limit in script.

* ci: Attempts fix described in kucherenko/jscpd#160.
@ryasmi
Copy link
Author

ryasmi commented Sep 10, 2018

Thanks @kucherenko, using "1.0" works for now.

@ryasmi ryasmi closed this as completed Sep 10, 2018
@ryasmi ryasmi reopened this Sep 10, 2018
@ryasmi
Copy link
Author

ryasmi commented Sep 10, 2018

Sorry accidentally close this.

@CrazyEraserUK
Copy link

+1 seeing this too

kucherenko pushed a commit that referenced this issue Sep 21, 2018
fix(#160) add ability to use integer and float numbers for limit
1355947
@kucherenko
Copy link
Owner

Fixed in jscpd@0.6.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kucherenko @CrazyEraserUK @ryasmi