Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'pkg/kudoctl/util/kudo' into a cleaned-up package under 'pkg' #1002

Open
nfnt opened this issue Oct 25, 2019 · 0 comments
Open

Refactor 'pkg/kudoctl/util/kudo' into a cleaned-up package under 'pkg' #1002

nfnt opened this issue Oct 25, 2019 · 0 comments

Comments

@nfnt
Copy link
Member

nfnt commented Oct 25, 2019

What would you like to be added:
The pkg/kudoctl/util/kudo package provides functions to interface with the v1alpha1 clientset. Most functions wrap function arguments and translate types, but there's also functions to, e.g., install a package. As this can be considered a higher-level wrapping of KUDO API functions, these functions shouldn't live under a util folder. Furthermore, some cleaning up is necessary, some function names can be misleading and some function could be split up into smaller functions.

Why is this needed:
Better separation of concerns, clearer interface to clientset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant