Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metrics/Test for Metrics #1433

Open
ANeumann82 opened this issue Mar 19, 2020 · 1 comment
Open

Add Metrics/Test for Metrics #1433

ANeumann82 opened this issue Mar 19, 2020 · 1 comment

Comments

@ANeumann82
Copy link
Member

What would you like to be added:
As we had a pretty ugly regression with #1421 that should have been obvious if we checked the reconcile-loop length in our e2e tests, we should look into this. The controller-runtime adds some common metrics, we should use them.

  • Add a test to validates a max-duration for a reconcile
  • Expose KUDO metrics somehow useful
  • Maybe add logging about slow reconciles?
  • Can we have a check for the number of API calls made in each reconcile run?

Why is this needed:
Prevent performance regressions in the future.

@alenkacz
Copy link
Contributor

A bit related to #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants