You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to add a verifier That checks that Param.Trigger values are found in the set of the plan names and ERROR if not.
Closely related is: #1618
Prior to this PR, we didn't check trigger when warning that a param is not used... now we need to check if the param.trigger value is sensical value and if not provide an error. The example in verfiy_parameters_test.go is a good example. the newly added {Name: "TRIGGER_ONLY", Trigger: "foo"}, is a trigger on a plan that does not exist. While this may be ok for the current impl... we should have a verifier that errors for trigger that do not exist.
The text was updated successfully, but these errors were encountered:
We need to add a verifier That checks that Param.Trigger values are found in the set of the plan names and ERROR if not.
Closely related is: #1618
Prior to this PR, we didn't check trigger when warning that a param is not used... now we need to check if the param.trigger value is sensical value and if not provide an error. The example in
verfiy_parameters_test.go
is a good example. the newly added{Name: "TRIGGER_ONLY", Trigger: "foo"},
is a trigger on a plan that does not exist. While this may be ok for the current impl... we should have a verifier that errors for trigger that do not exist.The text was updated successfully, but these errors were encountered: