Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup docs #1139

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fix cleanup docs #1139

merged 2 commits into from
Dec 6, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Dec 5, 2019

No description provided.

Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, IMO finalizers are an implementation detail to ensure that a cleanup plan is run during deletion. So the goal is to run a cleanup plan and the existing documentation covers that. WDYT?

@alenkacz
Copy link
Contributor Author

alenkacz commented Dec 5, 2019

@nfnt the fact that a cleanup plan is executed is not a concern of controller anymore, that is an implementation detail of startExecutionPlan so I would say we either drop that bubble altogether or leave the finalizers there as that's the only code concerning controller right now

Actually this is obsolete as well, as that part does not start any plan anymore
2. Check if the object is being deleted, start cleanup plan

@nfnt
Copy link
Member

nfnt commented Dec 5, 2019

You're right, these decisions are done by the Instance, ahem, instance, not the controller. 👍

@alenkacz alenkacz merged commit 73f9699 into master Dec 6, 2019
@alenkacz alenkacz deleted the av/fix-cleanup-docs branch December 6, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants