Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup docs #1139

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fix cleanup docs #1139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9827e9b
Fix cleanup docs
alenkacz Dec 5, 2019
e7f69f6
update another comment
alenkacz Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/controller/instance/instance_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ func (r *Reconciler) SetupWithManager(
// |
// v
// +-------------------------------+
// | Start cleanup plan if object |
// | is being deleted |
// | Update finalizers if cleanup |
// | plan exists |
// +-------------------------------+
// |
// v
Expand Down Expand Up @@ -147,7 +147,7 @@ func (r *Reconciler) Reconcile(request ctrl.Request) (ctrl.Result, error) {
return reconcile.Result{}, err // OV not found has to be retried because it can really have been created after Instance
}

// ---------- 2. Check if the object is being deleted, start cleanup plan ----------
// ---------- 2. Check if the object is being deleted ----------

if !instance.IsDeleting() {
if _, hasCleanupPlan := ov.Spec.Plans[kudov1beta1.CleanupPlanName]; hasCleanupPlan {
Expand Down