Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-bindata to embed YAML files with CRDs. #1211

Merged
merged 7 commits into from
Dec 20, 2019
Merged

Commits on Dec 19, 2019

  1. Remove the unused crdVersion from CRD.

    It was never used (verified by eyeballing `git log -p` all the way
    down), we don't seem to know what it's for, and it has no counterpart in
    the structs.
    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    4500525 View commit details
    Browse the repository at this point in the history
  2. Rename the CRD files.

    This is in preparation for moving to `controller-gen`, which is somewhat
    opinionated in that it does not allow us to pick the exact file names.
    
    I guess we do not really care what these are called anyway - the only
    place where these names show up is this integration test.
    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    843e5a4 View commit details
    Browse the repository at this point in the history
  3. goimports

    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    38412bd View commit details
    Browse the repository at this point in the history
  4. Use go-bindata to embed YAML files with CRDs.

    Also add go-bindata to the `generate` target, and a README.
    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    de800ba View commit details
    Browse the repository at this point in the history
  5. Remove option to write manifests from test.

    They are the authoritative *source* now.
    
    Keep the test around as a way of making sure the file generated by
    go-bindata is up-to-date.
    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    7e09768 View commit details
    Browse the repository at this point in the history
  6. Update README.

    porridge committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    a5f1557 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Configuration menu
    Copy the full SHA
    bebe5d3 View commit details
    Browse the repository at this point in the history