Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump code generator and remove stale workaround note. #1244

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

porridge
Copy link
Member

@porridge porridge commented Jan 2, 2020

What this PR does / why we need it:

We can now use the version with fixed GOBIN/GOPATH support and remove the note
in instructions.
Apart from some changed dependencies, there do not seem to be any changes.

See #1051 (comment) and #1069 for old context.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great description and helping with the context! very appreciated!

Nice work!!

@kensipe kensipe merged commit c85e68c into master Jan 2, 2020
@kensipe kensipe deleted the rm-code-gen-workaround branch January 2, 2020 16:11
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants