Simplified and updated go.mod #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandgrillet
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
Hi @armandgrillet - thanks for your contribution! I think this should be OK. We were fighting some diamond dependency issues, so pending builds of the CLI and controller working I think we're OK to merge this. |
gerred
approved these changes
Jan 31, 2020
|
@armandgrillet You will still need to depend on the SHA for this at the moment until we make a tagged release for the next version of KUDO, FYI. |
|
@gerred Thanks for the information! I can use a SHA for my use case so it's all good 😄 . |
nfnt
reviewed
Feb 3, 2020
| k8s.io/apiextensions-apiserver v0.0.0-20190918161926-8f644eb6e783 | ||
| k8s.io/apimachinery v0.16.6 | ||
| k8s.io/client-go v0.16.6 | ||
| k8s.io/code-generator v0.16.6 |
There was a problem hiding this comment.
Yes, as the mesage on #1244 explained, this is the version which fixes kubernetes/code-generator#87 (which only surfaces in some environments).
Downgrading means you'll re-introduce the issue @nfnt
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Bumped most k8s.io packages to v0.16.6 Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Bumped most k8s.io packages to v0.16.6 Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating repositories depending on Kudo and I have faced some issues due to the use of
k8s.io/client-go v11.0.0+incompatible. I have thus updated KUDO's package dependencies to be clearer by using recently tagged k8s.io releases instead of SHAs related to outdated versions such as v0.16.2.After these two commits, using
go mod tidydoes not change a thing andmakesuccessfully runs. I am not sure yet that these changes will fix my issue but they should do no harm to the kudo repository and improve the dependency management.I have not updated
k8s.io/apiextensions-apiserverdue to the warning message../go/pkg/mod/k8s.io/component-base@v0.16.6/metrics/legacyregistry/registry.go:44:9: undefined: prometheus.InstrumentHandlerwhen runninggo get k8s.io/apiextensions-apiserver@v0.16.6.