Add verifier support for the special $ variable.
#1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a test case. Also fix some typos found when reading related code.
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
porridge
force-pushed
the
dollar-variable
branch
from
b911edf
to
be1a5b4
Compare
|
fantastic!! I was aware we needed to handle this... happy to see a solution. I will review in detail shortly. |
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
This includes a test case. Also fix some typos found when reading related code. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
This was referenced Mar 19, 2020
zmalik
added a commit
to kudobuilder/operators
that referenced
this pull request
Mar 24, 2020
) - add Toggle task for all features present in KUDO Kafka - update the minimal KUDO version to 0.11.0 because of Toggle Task usage - add a section of planned releases in `README.md` for unreleased versions to avoid any confusion - separate `deploy` and `update` plans, to avoid running pipe task in each update. This should also reduce the test duration in all CI pipelines - modify the autoTLS feature so it only generates certs when enabled - migrate mirrormaker and user workload to use `apps/v1` - remove the usage of `$root` as kudobuilder/kudo#1255 was merged and released Signed-off-by: Zain Malik <zmalikshxil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the verifier for the most basic but also the most useful case in #1201 - which is to be able to refer to the "top-level" from anywhere in the tree.
It does not add support for general user-verified variables to the verifier (which I think might be much harder if not impossible for a static checker).
This includes a test case.
Also fix some typos found when reading related code.