add toggle features for Kafka and minor fixes around operator plan #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zain Malik <zmalikshxil@gmail.com>
zmalik
force-pushed
the
zain/kafka-toggle
branch
from
880fa50
to
0ce3e00
Compare
zen-dog
reviewed
Mar 19, 2020
ANeumann82
reviewed
Mar 19, 2020
ANeumann82
reviewed
Mar 19, 2020
| - health-check.yaml | ||
| - enable-tls.yaml | ||
| - user-workload.yaml | ||
| # task used to restrict patching sts where it is not allowed | ||
| - name: not-allowed | ||
| kind: Dummy |
There was a problem hiding this comment.
On the topic of the not-allowed task: Would it make sense to have a task type "Fail" that simply FATAL_ERRORs the plan with a specified message?
There was a problem hiding this comment.
yeah we need to do another round here now after many releases
There was a problem hiding this comment.
Actually, I think we really need immutable parameters. Having the task is ok-ish for now, but the parameters still get set even if the plan fails. And on the next run of update they're applied
There was a problem hiding this comment.
And our admission controller would be able to prevent changing immutable parameters. We need a KEP for that but otherwise, the solution can be pretty simple.
ANeumann82
approved these changes
Mar 19, 2020
zen-dog
reviewed
Mar 19, 2020
Signed-off-by: Zain Malik <zmalikshxil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR:
README.mdfor unreleased versions to avoid any confusiondeployandupdateplans, to avoid running pipe task in each update. This should also reduce the test duration in all CI pipelinesapps/v1$rootas Add verifier support for the special$variable. kudo#1255 was merged and released