Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Verify to Support Templates with user defined prefixes #1201

Closed
kensipe opened this issue Dec 17, 2019 · 4 comments
Closed

Package Verify to Support Templates with user defined prefixes #1201

kensipe opened this issue Dec 17, 2019 · 4 comments
Assignees
Milestone

Comments

@kensipe
Copy link
Member

kensipe commented Dec 17, 2019

What would you like to be added:
https://github.com/kudobuilder/operators/blob/master/repository/kafka/operator/templates/external-service.yaml
shows an example which can be boiled down to:

{{- $root := . -}}
{{ range $i, $v := until (int .Params.BROKER_COUNT) }}
---
apiVersion: v1
kind: Service
metadata:
  name: {{ $root.Name }}-kafka-{{ $v }}-external
  namespace: {{ $root.Namespace }}
spec:
  type: {{ $root.Params.EXTERNAL_ADVERTISED_LISTENER_TYPE }}
{{end}}

The $root for implicits and for Params needs to be supported for validation.

@kensipe kensipe added this to the 0.10.0 milestone Dec 17, 2019
@kensipe
Copy link
Member Author

kensipe commented Dec 17, 2019

@zmalik anything else to add here?

@zmalik
Copy link
Member

zmalik commented Dec 17, 2019

@kensipe this looks good and covers any use cases I can think around user-defined variables in templates

@porridge
Copy link
Member

porridge commented Jan 9, 2020

@zmalik please let us know whether the merged change (will be in 0.10.0) to support the $ variable works as expected.

@porridge
Copy link
Member

porridge commented Jan 9, 2020

Actually let me just close this as fixed, and you can reopen if this is still a problem in 0.10.0.

@porridge porridge closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants