Fix tar test. #1409
Merged
Fix tar test. #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `os.Open` calls were always returning a nil and an error, so the test was joyfully comparing that nil==nil. This highlights the importance of *not* ignoring errors. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
The `os.Open` calls were always returning a nil and an error, so the test was joyfully comparing that nil==nil. This highlights the importance of *not* ignoring errors. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
zen-dog
pushed a commit
that referenced
this pull request
Mar 11, 2020
The `os.Open` calls were always returning a nil and an error, so the test was joyfully comparing that nil==nil. This highlights the importance of *not* ignoring errors. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
os.Opencalls were always returning a nil and an error, so thetest was joyfully comparing that nil==nil.
This highlights the importance of not ignoring errors.
Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com