Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tar test. #1409

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix tar test. #1409

merged 1 commit into from
Mar 10, 2020

Commits on Mar 10, 2020

  1. Fix tar test. 

    The `os.Open` calls were always returning a nil and an error, so the
test was joyfully comparing that nil==nil.

This highlights the importance of *not* ignoring errors.

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
    @porridge
    porridge committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2b6e96c View commit details
    Browse the repository at this point in the history