Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer API #11

Open
johnmaguire opened this issue Apr 2, 2015 · 3 comments
Open

Developer API #11

johnmaguire opened this issue Apr 2, 2015 · 3 comments

Comments

@johnmaguire
Copy link

Hi! I remember seeing this project a while ago and really loving it. I was wondering if:

  1. You might be willing to incorporate a developer API into the project. (This would be great for an IRC bot plugin I plan to write soon, so people pasting Spotify / GMusic links won't annoy users of the other service.)
  2. I see you haven't made a ton of changes to this project lately (I know how side projects go :)), so I was wondering, if point number 1 is acceptable, if you'd be interested in me trying to write this functionality and submitting a pull request. :)

Alternatively, I also see that I could use the endpoint used in the Chrome extension. Would you prefer that fact isn't utilized? (i.e. Should I assume that is meant only for internal use, and it would be rude to use?)

Thanks!

@kudos
Copy link
Owner

kudos commented Apr 14, 2015

Thanks for the kind words! Sorry for the delay in getting back to you, I seem to have screwed up my notifications for personal projects.

I don't want to return machine readable data from an API, simply because the third-party API tokens I have have limits. I'd be happy for people to bring their own tokens somehow, whether it's per request or stored in the database. When stored in the DB you'd effectively be exchanging your collection of API tokens for a match.audio API token. Does that make sense?

In terms of using the same endpoint as the chrome extension, that's totally fine. The only reason it's not documented is for a lack of time.

@johnmaguire
Copy link
Author

Pretty sure that all makes total sense. To reiterate for clarity:

  1. You're not opposed to a machine-readable API, but the user would have to provide relevant API keys for whichever services you're/they're accessing (e.g. Spotify). And possibly this could be stored in a DB for developers so they can just pass along a match.audio API key and you can route as necessary.
  2. It's fine to send users to the search page on match.audio, just don't automate scraping the response returned by the server.

Correct? :)

@kudos
Copy link
Owner

kudos commented Apr 14, 2015

Correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants