feat: support React v17 #1049
Closed
feat: support React v17 #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
|
Deploy preview for smarthr-ui ready! Built with commit 24bed98 |
|
As I expected, the |
koba04
force-pushed
the
support-reactv17
branch
from
919acc1
to
f4638f1
Compare
koba04
force-pushed
the
support-reactv17
branch
2 times, most recently
from
260cae5
to
16d69f9
Compare
koba04
changed the title
koba04
commented
Oct 22, 2020
package.json
Outdated
| @@ -18,6 +18,7 @@ | |||
| "@storybook/addon-a11y": "^6.0.26", | |||
| "@storybook/addon-essentials": "^6.0.26", | |||
| "@storybook/addon-storysource": "^6.0.26", | |||
| "@storybook/addon-viewport": "^6.0.26", | |||
There was a problem hiding this comment.
This is necessary because we use the dependency directly at https://github.com/kufu/smarthr-ui/blob/support-reactv17/.storybook/preview.js.
The addon is installed via @storybook/addon-essentials but it isn't guaranteed whether the addon is placed in the root node_modules/ directory.
In this PR, the addon has been installed in the @storybook/addon-essentials's node_modules/ directory, which breaks our build for storybook.
To fix this, I've installed @storybook/addon-viewport explicitly.
koba04
requested review from
AtsushiM and
negiandleek
and removed request for
a team
koba04
force-pushed
the
support-reactv17
branch
from
abfe8a7
to
3ba5f1e
Compare
1 task
* fix: change to add aria-label to icon (#1110) * chore(deps): update dependency @types/react-dom to ^16.9.9 (#1113) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency eslint to ^7.12.1 (#1114) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency ts-jest to ^26.4.3 (#1098) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency typescript to ^4.0.5 (#1115) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update babel monorepo (#1077) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update storybook monorepo to ^6.0.28 (#1117) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency lint-staged to ^10.5.1 (#1118) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Masakatsu Tokita <lily.yarn.5@gmail.com> * fix: change the minimum value of from props in the calendar component (#1122) * fix: change the minimum value of from props in the calendar component * test: fix calendar test * feat: add darkenAmount argument to hoverColor method (#950) * fix: invalid html width attribute (#1105) * feat: add "from" and "to" props to DatePicker component (#1123) * fix: make StatusLabel vertical center alignment (#879) * fix: improve StatusLabel style * test: update snapshot * chore: reset css on storybook (SHRUI-163) (#1108) * chore: add styled-reset * chore: add reset css toolbar on storybook * fix: DatePicker bugs (#1091) * fix: fix portal container * fix: fix handling of value prop * chore(deps): update dependency mem to v8 (#1055) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: wmoai <wmoaism@gmail.com> * chore(deps): update dependency jest to ^26.6.3 (#1131) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency ts-loader to ^8.0.10 (#1133) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency @babel/helper-compilation-targets to ^7.12.5 (#1129) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency styled-reset to ^4.3.0 (#1135) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com> * fix: add box-sizing: border-box to textarea (#1060) fix: add semicolon Co-authored-by: Yuta YAMAMOTO <yuta.yamamoto@yuta.yamamoto> * chore(deps): update dependency storycap to v3 (#1014) * chore(deps): update dependency storycap to v3 * chore: add puppeteer Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: wmoai <wmoaism@gmail.com> * feat: add border style to MessageDialog (#1059) Co-authored-by: wmoai <wmoaism@gmail.com> * docs: add readme for flash-message (#1062) * docs: add readme for flash-message * fix: update FlashMessage README * feat: change the attribute of radius (#1080) * feat: change the attribute of radius to classname * feat: apply transient props * fix: change theme props to transient props (#1081) Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com> * fix: pass undefined to accept instead of blank string (#1121) Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com> * Fix footer color to brand color (#814) * fix: change Footer color to Brand Color * chore: remove HEADER_GREEN from palette Co-authored-by: shota takata <36581513+im36-123@users.noreply.github.com> Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com> * fix: add aria-describedby (#1137) * fix: shifting of index when IndexNav's ListItem is inserted into a new line (#1138) * chore(deps): update dependency styled-components to ^5.2.1 (#1119) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: adjust input size to be same with wrapper (#1139) * chore(deps): update dependency prettier-config-smarthr to v1 (#1120) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: negiandleek <youya66.official@gmail.com> * chore(deps): update dependency puppeteer to ^5.4.1 (#1144) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency styled-reset to ^4.3.1 (#1145) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency ts-jest to ^26.4.4 (#1132) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency ts-loader to ^8.0.11 (#1146) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency dayjs to ^1.9.6 (#1130) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Masakatsu Tokita <lily.yarn.5@gmail.com> Co-authored-by: nabeliwo <hiroki.c.watanabe@gmail.com> Co-authored-by: KANAMORI Yu <y.kinmori@gmail.com> Co-authored-by: wmoai <wmoaism@gmail.com> Co-authored-by: Yuta Yamamoto <ftbae1@gmail.com> Co-authored-by: Yuta YAMAMOTO <yuta.yamamoto@yuta.yamamoto> Co-authored-by: Shinichi Kogiso <kuusai1998@gmail.com> Co-authored-by: shota takata <36581513+im36-123@users.noreply.github.com> Co-authored-by: negiandleek <youya66.official@gmail.com>
|
I'd like to take this as #1151 so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
React has released RC versions for v17, so I'd like to test the version with
smarthr-ui.What I did
I've updated peerDependencies and devDependencies to allow React v17.
Capture