Use language server to get proper reflection types #505
Conversation
# Conflicts: # package.json
# Conflicts: # src/utils.ts
| @@ -7,7 +7,8 @@ | |||
| "scripts": { | |||
| "build": "cpx index.d.ts dist/ && tsc -p .", | |||
| "build:watch": "cpx index.d.ts dist/ && tsc -p . -w", | |||
There was a problem hiding this comment.
ran into several issues where I'd like to clean the node_modules inside tests also, so I'm sure that there's no old files left-over
|
I haven't reviewed this in detail but willing to approve it if you're happy with the state of this PR @GeeWee |
|
Please publish a new version |
|
published |
|
@GeeWee it's a bit weird that you've squashed the cherry-picked commits from my PR 😕 now there's no history about my contribution 😞 |
|
Sorry - I'm not good with git. Didn't mean to steal credit or anything. Would it be okay with you to submit a PR that adds your name to the authors list? |
|
@19majkel94 please accept my apologies as well. We'd be more than happy to merge in a PR adding your name to the authors list. I realize this doesn't entirely make up. If you'd like, I'm also fine with attributing credit in a comment with a link to your profile and to this PR alongside the changes you committed. |
Step to closing #439.
We're adding an
useExperimentalLanguageServerflag to test it out how it'll work in real life. I'm not sure about the speed aspects, or other surprises we might get - so I'm thinking we'll get some real life feedback before revealing it in the Readme or anything like that.