Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshService deeper integration #2470

Closed
lahabana opened this issue Apr 22, 2024 · 4 comments
Closed

MeshService deeper integration #2470

lahabana opened this issue Apr 22, 2024 · 4 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@lahabana
Copy link
Contributor

Description

Policy attachment/inspect api should be usable from the GUI.

MeshGlobalService (or whatever this related to). MeshHostnameGenerator and other things like this.

TODO complete this issue with precise things to integrate with @jakubdyszkiewicz and @michaelbeaumont

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Apr 22, 2024
@lahabana lahabana added this to the 2.8.x milestone Apr 22, 2024
@michaelbeaumont
Copy link
Contributor

  • Service view - select services by type
    • Dropdown selector for service type
    • OR button per service type
  • Hostname generator view
    • We will already have this accessible from MeshService via status
    • Maybe we can show the same list in every Mesh
      • OR we add a new left-level entry for HostnameGenerators

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Apr 22, 2024
@jakubdyszkiewicz
Copy link
Contributor

Triage: another option is to just not show HostnameGenerator at all

@johncowen
Copy link
Contributor

johncowen commented May 22, 2024

Not super clear what (if anything) is to be done here at this point in time.

#2469 is covering basic list/summary/detail and covers this part of @michaelbeaumont s comment above:

Service view - select services by type
Dropdown selector for service type
OR button per service type

(we went for button per service type)

I think

  • Policy attachment/inspect api should be usable from the GUI.
  • HostnameGenerator and other things like this.

Are still work in progress from the backends perspective, and could be better to close this issue and create two new ones for these two points once its clear what's to be done.

@johncowen
Copy link
Contributor

I'm going to take this one out of 2.9.

Theres an issue to cover:

Policy attachment/inspect api should be usable from the GUI.

for 2.9 (#2880)

And I don't believe we are aiming for GUI support HostnameGenerator for 2.9.

But let me know if this still needs to be in 2.9, we can add back the milestone

@johncowen johncowen modified the milestones: 2.9.x, 2.10.x Sep 9, 2024
@lahabana lahabana closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants