New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The tidy
build target doesn't tidy all the modules
#2088
Comments
jpeach
changed the title
The
The Jun 3, 2021
tidy
build target dpesntidy
build target doesn't tidy all the modules
This updates the tidy target, but runs into module dependency problems
|
The embedded Go module for k8s/native was removed in #2360. Remaining modules are: ./go.mod
./pkg/transparentproxy/istio/go.mod
./vendored/github.com/prometheus/prometheus/go.mod But you can't tidy the istio submodule
|
jakubdyszkiewicz
pushed a commit
that referenced
this issue
Sep 22, 2021
This fixes #2088. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this issue
Sep 23, 2021
jpeach
added a commit
that referenced
this issue
Sep 23, 2021
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this issue
Sep 28, 2021
This fixes kumahq#2088. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this issue
Sep 28, 2021
This fixes kumahq#2088. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
If you do
make tidy
, it only runsgo mod tidy
on the modules in. ./api/ ./pkg/plugins/resources/k8s/native
.I was expecting it to be able to tidy all the modules in the repository.
xref #2087
The text was updated successfully, but these errors were encountered: