Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) fix "make tidy" #2818

Merged
merged 1 commit into from Sep 22, 2021
Merged

chore(ci) fix "make tidy" #2818

merged 1 commit into from Sep 22, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Sep 22, 2021

Summary

Fix "make tidy".

Full changelog

N/A

Issues resolved

Fix #2088.

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

This fixes #2088.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner September 22, 2021 04:13
@codecov-commenter
Copy link

Codecov Report

Merging #2818 (9976ebd) into master (7756bb3) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2818      +/-   ##
==========================================
+ Coverage   52.05%   52.08%   +0.02%     
==========================================
  Files         882      882              
  Lines       51321    51321              
==========================================
+ Hits        26715    26728      +13     
+ Misses      22483    22468      -15     
- Partials     2123     2125       +2     
Impacted Files Coverage Δ
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/kds/client/sink.go 67.56% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7756bb3...9976ebd. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit e48d37a into kumahq:master Sep 22, 2021
mergify bot pushed a commit that referenced this pull request Sep 22, 2021
This fixes #2088.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit e48d37a)
@jpeach jpeach deleted the chore/fix-check-tidy branch September 22, 2021 23:27
jpeach added a commit that referenced this pull request Sep 23, 2021
This fixes #2088.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit e48d37a)
jpeach added a commit that referenced this pull request Sep 23, 2021
This fixes #2088.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit e48d37a)

Co-authored-by: James Peach <james.peach@konghq.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
This fixes kumahq#2088.

Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
This fixes kumahq#2088.

Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tidy build target doesn't tidy all the modules
3 participants