Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mTLS certs as a client cert when executing Envoy Admin actions from CP #4582

Closed
jakubdyszkiewicz opened this issue Jul 11, 2022 · 1 comment · Fixed by #4676
Closed
Assignees
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

To avoid introducing another set of certs that user needs to learn, we are using DP server certs as client certs when CP is executing Envoy Admin actions. This can be a problem when user will provide their own DP server certs that cannot be used as client certs. It's visible as

2022-06-28T10:55:44.930+0200 ERROR Could not get config_dump {"error": "error response from Zone CP: unable to send GET to config_dump: Get \"https://<IP>:<PORT>/config_dump\": remote error: tls: unsupported certificate", "errorVerbose": "error response from Zone CP: unable to send GET to config_dump: Get \"https://<IP>:<PORT>/config_dump\": remote error: tls: unsupported certificate\ngithub.com/kumahq/kuma/pkg/envoy/admin.

When mTLS is enabled, we should generate a client cert for CP from the enabled backend for the given mesh.
This way we know that the client cert meets all the requirements because we are using it for service-to-service mTLS.

@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature kind/improvement Improvement on an existing feature and removed kind/feature New feature labels Jul 11, 2022
@jakubdyszkiewicz jakubdyszkiewicz self-assigned this Jul 11, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/bug A bug and removed triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Jul 25, 2022
@tibuntu
Copy link

tibuntu commented Aug 24, 2022

Hey @jakubdyszkiewicz,

just wanted to leave quick feedback here. We just upgraded our Kuma to 1.8.0 and with that, the issue is finally gone.
Thanks and kudos from us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants