Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(transparentproxy) iptables DNS rules order #1821

Merged
merged 5 commits into from
Apr 15, 2021
Merged

chore(transparentproxy) iptables DNS rules order #1821

merged 5 commits into from
Apr 15, 2021

Conversation

nickolaev
Copy link
Contributor

Summary

Make sure the UDP DNS rules precede everything else

Documentation

  • Internal

chore(transparentproxy) iptables DNS rules order
9a98f5b 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev requested a review from a team as a code owner April 15, 2021 08:25
Nikolay Nikolaev added 2 commits April 15, 2021 13:17
chore(transparentproxy) add --redirect-dns-upstream-target-chain
ab13671 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
fix(*) make check
0dad92b 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
bartsmykla
bartsmykla approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Nikolay Nikolaev added 2 commits April 15, 2021 14:10
fix(*) golden files
e0ed1a4 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
test(kumactl) uninstall transparent proxy
31af89c 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Apr 15, 2021
Merged
@jakubdyszkiewicz jakubdyszkiewicz merged commit 0ca14da into master Apr 15, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/iptables_for_dns_rule_order branch April 15, 2021 12:56
mergify bot pushed a commit that referenced this pull request Apr 15, 2021
chore(transparentproxy) iptables DNS rules order (#1821)
ddfb916 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
(cherry picked from commit 0ca14da)
@mergify mergify bot mentioned this pull request Apr 15, 2021
Merged
nickolaev pushed a commit that referenced this pull request Apr 15, 2021
@mergify
chore(transparentproxy) iptables DNS rules order (#1821) (#1823)
7c07626 
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
(cherry picked from commit 0ca14da)

Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev restored the chore/iptables_for_dns_rule_order branch April 15, 2021 17:07
@nickolaev nickolaev deleted the chore/iptables_for_dns_rule_order branch June 17, 2021 12:10
@jpeach jpeach mentioned this pull request Sep 6, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickolaev @jakubdyszkiewicz @bartsmykla