Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) replace goimports with gci #2489

Merged
merged 2 commits into from
Aug 5, 2021
Merged

chore(*) replace goimports with gci #2489

merged 2 commits into from
Aug 5, 2021

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Aug 4, 2021 •
edited by jpeach

Summary

Based on #2486 (comment)

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@lobkovilya
chore(*) replace goimports with gci
ec83c73 
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya lobkovilya requested a review from a team as a code owner August 4, 2021 07:19
@lobkovilya
chore(*) fix imports
b518b0f 
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya lobkovilya mentioned this pull request Aug 4, 2021
Merged
6 tasks
jpeach
jpeach approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lobkovilya lobkovilya merged commit d6acd79 into master Aug 5, 2021
@lobkovilya lobkovilya deleted the chore/replace-goimports-with-gci branch August 5, 2021 06:38
mergify bot pushed a commit that referenced this pull request Aug 5, 2021
@lobkovilya
chore(*) replace goimports with gci (#2489)
22b07f5 
(cherry picked from commit d6acd79)

# Conflicts:
#	pkg/dns/outbound.go
#	pkg/dns/outbound_test.go
#	pkg/plugins/runtime/k8s/controllers/pod_converter.go
#	pkg/plugins/runtime/k8s/controllers/pod_converter_test.go
#	pkg/xds/envoy/tls/v3/tls.go
#	pkg/xds/sync/dataplane_proxy_builder.go
#	pkg/xds/sync/dataplane_watchdog.go
@mergify mergify bot mentioned this pull request Aug 5, 2021
Merged
jpeach pushed a commit that referenced this pull request Aug 11, 2021
@lobkovilya @jpeach
chore(*) replace goimports with gci (#2489)
8e1aed3 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit d6acd79)
jpeach pushed a commit that referenced this pull request Aug 11, 2021
@mergify @lobkovilya
chore(*) replace goimports with gci (#2489) (#2496)
491f5c1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit d6acd79)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @jpeach