chore(kumactl) remove kumactl plugin hooks #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only user of the kumactl plugin hooks was the gateway plugin. Improved protobuf codegen means that we don't need this mechanism to register gateway types for kumactl any more, and we can consolidate the registration code in the gateway plugin. This fixes #2503. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
==========================================
+ Coverage 52.19% 52.23% +0.03%
==========================================
Files 866 865 -1
Lines 48304 48281 -23
==========================================
+ Hits 25214 25221 +7
+ Misses 21050 21016 -34
- Partials 2040 2044 +4
Continue to review full report at Codecov.
|
lahabana
approved these changes
Aug 6, 2021
jakubdyszkiewicz
approved these changes
Aug 6, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
(cherry picked from commit 9ab4c8f) # Conflicts: # pkg/plugins/runtime/gateway/enabled.go
jpeach
added a commit
that referenced
this pull request
Aug 9, 2021
(cherry picked from commit 9ab4c8f)
jpeach
added a commit
that referenced
this pull request
Aug 9, 2021
(cherry picked from commit 9ab4c8f) Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Aug 11, 2021
(cherry picked from commit 9ab4c8f) Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
(cherry picked from commit 9ab4c8f) Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
Remove files that were left over from the previous backport in #2519. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
Remove files that were left over from the previous backport in #2519. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
…or` (backport #2511) (#2527) * chore(kumactl) remove kumactl plugin hooks (#2508) Remove files that were left over from the previous backport in #2519. Signed-off-by: James Peach <james.peach@konghq.com> * chore(tools): Simplify resource-gen.go by generating`ResourceDescriptor` (#2511) This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 5721243) Co-authored-by: James Peach <james.peach@konghq.com> Co-authored-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The only user of the kumactl plugin hooks was the gateway plugin.
Improved protobuf codegen means that we don't need this mechanism to
register gateway types for kumactl any more, and we can consolidate the
registration code in the gateway plugin.
Full changelog
N/A
Issues resolved
Fix #2503
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.