chore(tools): Simplify resource-gen.go by generatingResourceDescriptor
#2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceDescriptor` This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
@jpeach I think this is the last one :) It also adds the kumactl for gateway for free! I need to add my virtual-outbound policy after so I'll be able to see how this works out. |
Codecov Report
@@ Coverage Diff @@
## master #2511 +/- ##
=======================================
Coverage 52.30% 52.31%
=======================================
Files 867 865 -2
Lines 48182 48098 -84
=======================================
- Hits 25204 25161 -43
+ Misses 20942 20903 -39
+ Partials 2036 2034 -2
Continue to review full report at Codecov.
|
jpeach
approved these changes
Aug 9, 2021
…source-gen Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
chore/simpler-resource-gen
branch
from
16509d9
to
a135b91
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
…or` (#2511) This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 5721243) # Conflicts: # api/mesh/v1alpha1/gateway.pb.go # api/mesh/v1alpha1/gateway.proto # app/kuma-dp/cmd/dataplane.go # app/kuma-dp/cmd/run.go # app/kumactl/cmd/apply/apply_test.go # app/kumactl/cmd/delete/delete.go # app/kumactl/cmd/get/get.go # app/kumactl/cmd/get/get_dataplanes_test.go # app/kumactl/cmd/get/get_external_services_test.go # app/kumactl/cmd/get/get_healthchecks_test.go # app/kumactl/cmd/get/get_proxytemplates_test.go # app/kumactl/cmd/get/get_resource.go # app/kumactl/cmd/get/get_resources.go # app/kumactl/cmd/get/get_retries_test.go # app/kumactl/cmd/get/get_secrets_test.go # app/kumactl/cmd/get/get_test.go # app/kumactl/cmd/get/get_traffic_routes_test.go # mk/generate.mk # pkg/api-server/definitions/api.go # pkg/api-server/resource_api_client_test.go # pkg/api-server/resource_endpoints.go # pkg/api-server/server.go # pkg/core/resources/model/rest/resource.go # pkg/kds/cache/snapshot.go # pkg/kds/global/components.go # pkg/kds/global/components_test.go # pkg/kds/server/server_test.go # pkg/kds/types.go # pkg/kds/zone/components.go # pkg/kds/zone/components_test.go # pkg/plugins/runtime/gateway/enabled.go # pkg/plugins/runtime/gateway/register/enabled.go # pkg/plugins/runtime/k8s/webhooks/validation.go # tools/resource-gen.go
5 tasks
jpeach
pushed a commit
that referenced
this pull request
Aug 12, 2021
…or` (#2511) This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 5721243)
jpeach
pushed a commit
that referenced
this pull request
Aug 12, 2021
…or` (#2511) This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 5721243)
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
…or` (backport #2511) (#2527) * chore(kumactl) remove kumactl plugin hooks (#2508) Remove files that were left over from the previous backport in #2519. Signed-off-by: James Peach <james.peach@konghq.com> * chore(tools): Simplify resource-gen.go by generating`ResourceDescriptor` (#2511) This descriptor defines everything there is about a resource: - kds - kumactl - ws We then simplify a lot of the redundant code to use this descriptor. While refactoring some of the deep references to the global registry were removed Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 5721243) Co-authored-by: James Peach <james.peach@konghq.com> Co-authored-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This descriptor defines everything there is about a resource:
We then simplify a lot of the redundant code to use this descriptor.
While refactoring some of the deep references to the global registry were removed