Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): '/config_dump' request if Global CP is on Kubernetes #4363

Merged
merged 1 commit into from
May 27, 2022

Conversation

lobkovilya
Copy link
Contributor

Summary

Trim namespace suffix before making a /config_dump request if Global CP is on Kubernetes

Full changelog

  • trim namespace suffix

Issues resolved

Fix #4357

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

…r KDS

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner May 26, 2022 11:05
@lobkovilya lobkovilya changed the title fix(kuma-cp): /config_dump request if Global CP is on Kubernetes fix(kuma-cp): '/config_dump' request if Global CP is on Kubernetes May 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #4363 (082eaf3) into master (ecc63d4) will increase coverage by 0.02%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
+ Coverage   55.41%   55.43%   +0.02%     
==========================================
  Files         941      941              
  Lines       57125    57132       +7     
==========================================
+ Hits        31654    31670      +16     
+ Misses      22964    22959       -5     
+ Partials     2507     2503       -4     
Impacted Files Coverage Δ
pkg/core/bootstrap/bootstrap.go 66.55% <0.00%> (-0.45%) ⬇️
pkg/envoy/admin/kds_client.go 80.48% <100.00%> (+2.71%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️
pkg/plugins/resources/postgres/store.go 76.79% <0.00%> (+0.42%) ⬆️
pkg/mads/server/server.go 82.72% <0.00%> (+1.81%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
pkg/core/secrets/manager/global_manager.go 45.45% <0.00%> (+3.03%) ⬆️
...s/authn/api-server/tokens/admin_token_bootstrap.go 86.00% <0.00%> (+4.00%) ⬆️
pkg/core/tokens/default_signing_key.go 86.11% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc63d4...082eaf3. Read the comment docs.

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you check it manually with the gui?

@lobkovilya lobkovilya merged commit 7a3168a into master May 27, 2022
@lobkovilya lobkovilya deleted the fix/issue-4357 branch May 27, 2022 11:02
mergify bot pushed a commit that referenced this pull request May 27, 2022
…4363)

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit 7a3168a)
mergify bot added a commit that referenced this pull request May 27, 2022
…ackport #4363) (#4372)

fix(kuma-cp): '/config_dump' request if Global CP is on Kubernetes (#4363)

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit 7a3168a)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'/config_dump' doesn't work if Global CP on Kubernetes
3 participants