Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured #4501

Merged
merged 4 commits into from
Jun 29, 2022
Merged

fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured #4501

merged 4 commits into from
Jun 29, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jun 24, 2022 •
edited
Loading

Summary

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #4501 (53443bd) into master (8350473) will decrease coverage by 0.12%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #4501      +/-   ##
==========================================
- Coverage   55.54%   55.41%   -0.13%     
==========================================
  Files         947      947              
  Lines       58064    58068       +4     
==========================================
- Hits        32253    32180      -73     
- Misses      23268    23330      +62     
- Partials     2543     2558      +15
Impacted Files Coverage Δ
pkg/xds/secrets/secrets.go 74.59% <0.00%> (-0.41%) ⬇️
pkg/xds/generator/secrets/generator.go 81.96% <50.00%> (-4.24%) ⬇️
pkg/clusterid/creator.go 73.33% <0.00%> (-26.67%) ⬇️
pkg/insights/components.go 58.33% <0.00%> (-25.01%) ⬇️
pkg/core/tokens/default_signing_key.go 61.11% <0.00%> (-22.23%) ⬇️
pkg/defaults/mesh.go 64.28% <0.00%> (-21.43%) ⬇️
pkg/metrics/store/counter.go 74.54% <0.00%> (-10.91%) ⬇️
pkg/core/runtime/component/component.go 83.87% <0.00%> (-9.68%) ⬇️
.../apis/external_service/external_service_manager.go 35.48% <0.00%> (-9.68%) ⬇️
pkg/plugins/common/postgres/listener.go 46.15% <0.00%> (-7.70%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8350473...53443bd. Read the comment docs.

@michaelbeaumont michaelbeaumont linked an issue Jun 27, 2022 that may be closed by this pull request
Misconfigured CA settings on one mesh impact cert delivery to other meshes #4509
Closed
@lahabana
Copy link
Contributor

lahabana commented Jun 28, 2022 •
edited
Loading

This will be backported right? Does it need to be backports all the way to 1.5?

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Jun 28, 2022 •
edited
Loading

@lahabana Only 1.7, this came in with the cross-mesh change. I've doing this PR to the release branch. Nevermind I think there will be conflicts, maybe next release we can start doing fixes that way

@michaelbeaumont michaelbeaumont changed the base branch from master to release-1.7 June 28, 2022 08:28
@michaelbeaumont
fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured
1a04c83 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): add misconfigured mesh to cross-mesh gateway tests
43d08f5 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: try all mesh CAs if any failed last time
7dfde8f 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: use RunKubectlE
1236b2f 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the base branch from release-1.7 to master June 28, 2022 08:41
@michaelbeaumont michaelbeaumont marked this pull request as ready for review June 28, 2022 08:43
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 28, 2022 08:43
@michaelbeaumont michaelbeaumont merged commit 177eedf into kumahq:master Jun 29, 2022
@michaelbeaumont michaelbeaumont deleted the fix/mesh_ca_error branch June 29, 2022 07:33
mergify bot pushed a commit that referenced this pull request Jun 29, 2022
@michaelbeaumont @mergify
fix(kuma-cp): don't fail generation if other mesh CAs are misconfigur…
2e6570b 
…ed (#4501)

* fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured
* test(e2e): add misconfigured mesh to cross-mesh gateway tests
* fix: try all mesh CAs if any failed last time
* refactor: use RunKubectlE

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 177eedf)
@mergify mergify bot mentioned this pull request Jun 29, 2022
Merged
michaelbeaumont added a commit that referenced this pull request Jun 29, 2022
@michaelbeaumont
fix(kuma-cp): don't fail generation if other mesh CAs are misconfigur…
d887f35 
…ed (#4501)

* fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured
* test(e2e): add misconfigured mesh to cross-mesh gateway tests
* fix: try all mesh CAs if any failed last time
* refactor: use RunKubectlE

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 177eedf)
michaelbeaumont added a commit that referenced this pull request Jun 29, 2022
@mergify @michaelbeaumont
fix(kuma-cp): don't fail generation if other mesh CAs are misconfigur…
f2b1637 
…ed (backport #4501) (#4517)

fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured (#4501)

* fix(kuma-cp): don't fail generation if other mesh CAs are misconfigured
* test(e2e): add misconfigured mesh to cross-mesh gateway tests
* fix: try all mesh CAs if any failed last time
* refactor: use RunKubectlE

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 177eedf)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misconfigured CA settings on one mesh impact cert delivery to other meshes
4 participants
@michaelbeaumont @codecov-commenter @lahabana @jakubdyszkiewicz