Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gateway): don't create invalid envoy config when routes and listeners don't match #4837

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix(gateway): don't create invalid envoy config when routes and listeners don't match #4837

merged 2 commits into from
Aug 17, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 16, 2022 •
edited
Loading

Closes #4775

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- none
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- yes fix for release-1.8

@michaelbeaumont
test(gateway): add failing test
2ead657 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #4837 (c2e336e) into master (9985228) will increase coverage by 0.02%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #4837      +/-   ##
==========================================
+ Coverage   46.46%   46.48%   +0.02%     
==========================================
  Files         690      690              
  Lines       47069    47076       +7     
==========================================
+ Hits        21872    21885      +13     
+ Misses      23272    23269       -3     
+ Partials     1925     1922       -3
Impacted Files Coverage Δ
pkg/plugins/runtime/gateway/route/util.go 94.44% <85.71%> (-5.56%) ⬇️
...plugins/runtime/gateway/gateway_route_generator.go 94.03% <100.00%> (-0.04%) ⬇️
pkg/plugins/runtime/gateway/generator.go 85.00% <100.00%> (+0.83%) ⬆️
pkg/plugins/runtime/gateway/match/routes.go 100.00% <100.00%> (+33.33%) ⬆️
pkg/plugins/runtime/gateway/merge/routes.go 100.00% <100.00%> (ø)
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 89.36% <0.00%> (+6.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelbeaumont
fix(gateway): don't create invalid envoy config when routes and liste…
c2e336e 
…ners don't match

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Copy link
Contributor Author

@Mergifyio backport release-1.8

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022 •
edited
Loading

backport release-1.8

✅ Backports have been created

@michaelbeaumont michaelbeaumont marked this pull request as ready for review August 17, 2022 00:39
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 17, 2022 00:39
@michaelbeaumont michaelbeaumont merged commit 8b483ed into kumahq:master Aug 17, 2022
@michaelbeaumont michaelbeaumont deleted the fix/gateway_route_mismatch branch August 17, 2022 11:52
mergify bot pushed a commit that referenced this pull request Aug 17, 2022
@michaelbeaumont @mergify
fix(gateway): don't create invalid envoy config when routes and liste…
b331642 
…ners don't match (#4837)

* test(gateway): add failing test
* fix(gateway): don't create invalid envoy config when routes and listeners don't match

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 8b483ed)
@mergify mergify bot mentioned this pull request Aug 17, 2022
Merged
michaelbeaumont added a commit that referenced this pull request Aug 17, 2022
@mergify @michaelbeaumont
fix(gateway): don't create invalid envoy config when routes and liste…
0ba9cff 
…ners don't match (backport #4837) (#4841)

* test(gateway): add failing test
* fix(gateway): don't create invalid envoy config when routes and listeners don't match

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gateway: XDS error if a TCP route attaches to an HTTP listener
3 participants
@michaelbeaumont @codecov-commenter @jakubdyszkiewicz