Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in mAP calculation #2

Open
iTomxy opened this issue Sep 4, 2020 · 2 comments
Open

bug in mAP calculation #2

iTomxy opened this issue Sep 4, 2020 · 2 comments

Comments

@iTomxy
Copy link

iTomxy commented Sep 4, 2020

I found a bug in your code of calculating mAP, which lies in the function get_AP, originating from the wrong construction of the recall difference list.
I advise to change the final computing code of AP to AP = sum(l .* pl) / sum(l);.
For reference codes and testing case, see:

@kunhe
Copy link
Owner

kunhe commented Sep 7, 2020

Hi, thanks for your attention to this work and to the details. I will check on it this week.
Assuming it's indeed a bug, I'm wondering if you have numerical experiments on how much it affects results?

@iTomxy
Copy link
Author

iTomxy commented Sep 7, 2020

Not yet, but in the simple case I mentioned, it's a 0.558333 with 0.704167 discrepancy. Although it lies in the range given by the actual lower bound and upper bound, the computed upper bound is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants