Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced City_builder_game to a new level #4671

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

mohitgedar
Copy link
Contributor

PR Description 📜

Fixes #4665

  • I have enhanced the game to a new level , previously it was not doing very much , you had fixed amount of credit with which you just add some building , there is no start or end of the game , there is no win or lose.

  • After this enhancement the game have more features like factories produce pollution with time, they also produce money , parks reduce the pollution and cost money for maintaining them same is for houses , they generate pollution and need money for maintenance .

  • Also there are condition to win the game or lose the game , once the game end you can restart it , or if you want you can even restart in the middle of game.

  • Also made the game responsive to different screen sizes.


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

start of the game

City_Builder_Game

completed the game

City Builder Game - Brave 22-06-2024 12 30 09 PM

won the game

City Builder Game - Brave 22-06-2024 12 31 57 PM



Note :-

There was some trouble cloning the project , so I uploaded the files directly to forked repo , because of which ,you don't see what I changed and what I deleted , it shows that I deleted everything and rewrote everything.

I have enhanced the city builder game to new level, added new functionalities , improved it's looks ,also now the game have a start and a end
I have added the preview image of the game to GameZone/assets/images by the name City_Builder_Game.png
@kunjgit
Copy link
Owner

kunjgit commented Jun 22, 2024

Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@mohitgedar
Copy link
Contributor Author

hello @ishita-43 , please review this PR

@mohitgedar
Copy link
Contributor Author

hey @ishita-43 , now that your exams are complete , please review this PR.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 4, 2024
@kunjgit kunjgit merged commit 78651ef into kunjgit:main Jul 5, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 5, 2024

Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: City_Builder_Game needs complete renewal
3 participants