Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about max and min in RobustnessModell.cu #27

Open
weilongMao opened this issue Nov 26, 2021 · 1 comment
Open

about max and min in RobustnessModell.cu #27

weilongMao opened this issue Nov 26, 2021 · 1 comment

Comments

@weilongMao
Copy link

weilongMao commented Nov 26, 2021

In RobustnessModell.cu line 67 to 70,

			maxShift.x = fmaxf(s.x, shiftf.x);
			maxShift.y = fmaxf(s.y, shiftf.y);
			minShift.x = fminf(s.x, shiftf.x);
			minShift.y = fminf(s.y, shiftf.y);

It seems that you are finding minimum and maximum number of s, but it doesn't.
maybe the code below is your original idea

			maxShift.x = fmaxf(s.x, maxShift.x);
			maxShift.y = fmaxf(s.y, maxShift.y);
			minShift.x = fminf(s.x, minshift.x);
			minShift.y = fminf(s.y, minshift.y);
@kunzmi
Copy link
Owner

kunzmi commented Nov 30, 2021

Yes, looks like it...
Two possibilities: I had a super smart solution for a hidden problem that I don't recognize anymore and didn't explain in any comments in the code. Or it is just wrong.
Currently I tend to the second option ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants