Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cocoapods support #47

Closed
adrienbrault opened this issue Jan 18, 2016 · 8 comments
Closed

Add cocoapods support #47

adrienbrault opened this issue Jan 18, 2016 · 8 comments

Comments

@adrienbrault
Copy link
Contributor

No description provided.

@grabbou
Copy link
Collaborator

grabbou commented Jan 18, 2016

Last time I proposed that Kureev wasn't happy about it and I think that haven't changed since then, esp. given the fact we maintain rnpm. But I am leaving that up to him.

@Kureev
Copy link
Owner

Kureev commented Jan 20, 2016

What's the point for this now? I'd recommend to use rnpm for this purpose instead 😸

@adrienbrault
Copy link
Contributor Author

I added a new scheme to my project, and could not get the project to compile while using rnpm for react-native-blur.
Adding a podspec to the repo and using cocoapods fixed my build issues master...adrienbrault:patch-1

@Kureev
Copy link
Owner

Kureev commented Jan 20, 2016

Maybe it's not a scope of this story, but can you give me some insights why rnpm failed, please? We're looking forward to improve it and solving issues like that is the best way to build an awesome project 😜

@grabbou
Copy link
Collaborator

grabbou commented Jan 20, 2016

To me it doesn't matter. Pod spec is just one file, Cocoapods is just native package manager and I don't see any points against support it. The more choice, the better, especially given the fact Cocoapods pod specs are files you never modify in the future.

When there's PR - I am up to merging one.

@billinghamj
Copy link

I'd prefer to stick with Cocoapods also. React Native is just a part of my app - the app isn't solely React Native. Thus, I'd much rather use the standard iOS packaging tools as-is.

@adbl
Copy link

adbl commented Jan 31, 2016

@adrienbrault I see that you already have a patch for this at https://github.com/adrienbrault/react-native-blur/commits/patch-1 please PR it =)

@Kureev
Copy link
Owner

Kureev commented Feb 1, 2016

Done.

@Kureev Kureev closed this as completed Feb 1, 2016
lxp-git pushed a commit to Flickering-AI/react-native-blur that referenced this issue Mar 7, 2022
Fixing default imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants