Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs to reflect the use of context for handling overruns. #41

Open
kurin opened this issue Mar 6, 2018 · 2 comments
Open
Labels

Comments

@kurin
Copy link
Owner

kurin commented Mar 6, 2018

A bunch of Backblaze pods had their SSL certs expire, and b2 kept retrying until the user got annoyed and quit.

Should this have been a permanent error?

@kennylevinsen
Copy link

I think a TLS cert error could sensibly be considered fatal, as with any other error that suggests that the remote end is active but misconfigured and thus unable to be able to serve the request in the near future anyway.

For other things, the spin forever should probably just be dealt with through a user providing a context with timeout.

@kurin
Copy link
Owner Author

kurin commented Jul 6, 2018

I think the context in which this issue came up was that someone had issued an interactive command in a third party binary (like list backups) and then it just hanged. In a scenario where you're actually writing to b2, I would want blazer to spin and retry.

I think the right way to handle this is for the caller to set context timeouts appropriately for interactive uses.

@kurin kurin changed the title Should b2 spin forever or die eventually? Update the docs to reflect the use of context for handling overruns. Jul 6, 2018
@kurin kurin added bug and removed discussion labels Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants