Skip to content

Commit

Permalink
fix: Remove mouse wheel capture (#1452)
Browse files Browse the repository at this point in the history
## Description:
Remove mouse wheel capture on read only windows with no vertical
scrollable content.

## Is this change user facing?
YES

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1438
  • Loading branch information
adschwartz committed Oct 2, 2023
1 parent b2b55ae commit 2d35d77
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions engine/frontend/src/component/CodeEditor.js
Expand Up @@ -204,6 +204,7 @@ export const CodeEditor = (
scrollBeyondLastLine: false,
scrollbar: {
verticalScrollbarSize: scrollbarOption(readOnlySetting),
alwaysConsumeMouseWheel: !readOnly, // We want the original read only setting
},
renderLineHighlight: highlightLineOption(readOnlySetting),
}}
Expand Down
6 changes: 3 additions & 3 deletions engine/server/webapp/asset-manifest.json
@@ -1,13 +1,13 @@
{
"files": {
"main.css": "./static/css/main.d26dfda9.css",
"main.js": "./static/js/main.f622a552.js",
"main.js": "./static/js/main.62e418e6.js",
"index.html": "./index.html",
"main.d26dfda9.css.map": "./static/css/main.d26dfda9.css.map",
"main.f622a552.js.map": "./static/js/main.f622a552.js.map"
"main.62e418e6.js.map": "./static/js/main.62e418e6.js.map"
},
"entrypoints": [
"static/css/main.d26dfda9.css",
"static/js/main.f622a552.js"
"static/js/main.62e418e6.js"
]
}
2 changes: 1 addition & 1 deletion engine/server/webapp/index.html
@@ -1 +1 @@
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>Kurtosis Enclave Manager</title><script defer="defer" src="./static/js/main.f622a552.js"></script><link href="./static/css/main.d26dfda9.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
<!doctype html><html lang="en"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><title>Kurtosis Enclave Manager</title><script defer="defer" src="./static/js/main.62e418e6.js"></script><link href="./static/css/main.d26dfda9.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 2d35d77

Please sign in to comment.