Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When mouse is over CMD/ENTRYPOINT/ENV codeblock in service inspect screen, scroll is disabled #1438

Closed
mieubrisse opened this issue Sep 29, 2023 · 0 comments · Fixed by #1452 or #1453
Closed

When mouse is over CMD/ENTRYPOINT/ENV codeblock in service inspect screen, scroll is disabled #1438

mieubrisse opened this issue Sep 29, 2023 · 0 comments · Fixed by #1452 or #1453
Assignees
@adschwartz
Labels
bug Something isn't working bugbash frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend painful Painful bug

Comments

@mieubrisse
Copy link
Member

What's your CLI version?

0.83.14

Description & steps to reproduce

I'm tryign to scroll in https://www.loom.com/share/6d692e4a352e4b90a878fa2353d9572e?sid=30f24583-af86-4bb9-bd34-10e81fac0ce0 @ 2:36, but it's being captured by the codeblock and doing nothing

Desired behavior

the codeblock either:

  1. has something to scroll and so it's scrolled there or
  2. doesn't capture my scroll

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.
@mieubrisse mieubrisse added bug Something isn't working bugbash labels Sep 29, 2023
@github-actions github-actions bot added the painful Painful bug label Sep 29, 2023
@mieubrisse mieubrisse mentioned this issue Sep 29, 2023
Closed
@mieubrisse mieubrisse added the frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend label Sep 29, 2023
@mieubrisse mieubrisse mentioned this issue Sep 29, 2023
Open
@adschwartz adschwartz mentioned this issue Oct 2, 2023
Merged
adschwartz added a commit that referenced this issue Oct 2, 2023
@adschwartz
fix: Remove mouse wheel capture (#1452)
2d35d77 
## Description:
Remove mouse wheel capture on read only windows with no vertical
scrollable content.

## Is this change user facing?
YES

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1438
@kurtosisbot kurtosisbot mentioned this issue Oct 2, 2023
Merged
@adschwartz adschwartz self-assigned this Oct 2, 2023
adschwartz added a commit that referenced this issue Oct 2, 2023
@kurtosisbot @adschwartz
chore(main): release 0.83.16 (#1453)
1d0b05f 
🤖 I have created a release *beep* *boop*
---


##
[0.83.16](0.83.15...0.83.16)
(2023-10-02)


### Features

* add font
([#1454](#1454))
([75ce332](75ce332)),
closes [#1386](#1386)
* added --args-file to Kurtosis run
([#1451](#1451))
([fdc6220](fdc6220)),
closes [#1112](#1112)


### Bug Fixes

* Remove mouse wheel capture
([#1452](#1452))
([2d35d77](2d35d77)),
closes [#1438](#1438)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Anders Schwartz <adschwartz@users.noreply.github.com>
leoporoli pushed a commit that referenced this issue Oct 3, 2023
@adschwartz @leoporoli
fix: Remove mouse wheel capture (#1452)
7b2dda2 
## Description:
Remove mouse wheel capture on read only windows with no vertical
scrollable content.

## Is this change user facing?
YES

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
Closes #1438
leoporoli pushed a commit that referenced this issue Oct 3, 2023
@kurtosisbot @adschwartz @leoporoli
chore(main): release 0.83.16 (#1453)
c9b04b2 
🤖 I have created a release *beep* *boop*
---


##
[0.83.16](0.83.15...0.83.16)
(2023-10-02)


### Features

* add font
([#1454](#1454))
([75ce332](75ce332)),
closes [#1386](#1386)
* added --args-file to Kurtosis run
([#1451](#1451))
([fdc6220](fdc6220)),
closes [#1112](#1112)


### Bug Fixes

* Remove mouse wheel capture
([#1452](#1452))
([2d35d77](2d35d77)),
closes [#1438](#1438)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Anders Schwartz <adschwartz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adschwartz adschwartz

Labels
bug Something isn't working bugbash frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend painful Painful bug
Projects
None yet
Milestone
No milestone
2 participants
@mieubrisse @adschwartz