Skip to content

Commit

Permalink
fix: Stopping engine not required before switching cluster (#727)
Browse files Browse the repository at this point in the history
## Description:
Prior to updating the cluster, if stopping the engine fails, it just
logs a warning.

## Is this change user facing?
NO
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
  • Loading branch information
Guillaume Bouvignies committed Jun 14, 2023
1 parent 57ad2d9 commit af675c1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cli/cli/commands/cluster/set/set.go
Expand Up @@ -64,10 +64,10 @@ func run(ctx context.Context, flags *flags.ParsedFlags, args *args.ParsedArgs) e
return stacktrace.Propagate(err, "An error occurred creating an engine manager.")
}
if err = engineManagerOldCluster.StopEngineIdempotently(ctx); err != nil {
return stacktrace.Propagate(err, "An error occurred stopping the currently running engine prior to "+
"updating the cluster. The current engine needs to be stopped before the cluster can be updated. "+
"It can be done manually running `kurtosis %s %s`", command_str_consts.EngineCmdStr,
command_str_consts.EngineStopCmdStr)
logrus.Warnf("Kurtosis was not able to stop a potentially running engine on the cluster '%s'. This is not "+
"critical, it might be that the current cluster is not reachable anymore. In the worst case scenario, the "+
"engine will continue running in cluster '%s' until Kurtosis is switched back to it.", clusterPriorToUpdate,
clusterPriorToUpdate)
}

if err = clusterSettingStore.SetClusterSetting(clusterName); err != nil {
Expand Down

0 comments on commit af675c1

Please sign in to comment.