fix: Stopping engine not required before switching cluster #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
changed the title
adschwartz
approved these changes
Jun 14, 2023
Peeeekay
pushed a commit
that referenced
this pull request
Jun 15, 2023
🤖 I have created a release *beep* *boop* --- ## [0.78.5](0.78.4...0.78.5) (2023-06-15) ### Features * added ability for folks to copy files from the one time execution task ([#723](#723)) ([f1fcde1](f1fcde1)) * added run_sh to vscode plugin ([#738](#738)) ([337c994](337c994)) * Automatically inject the plan object if the first argument of the main function is `plan` ([#716](#716)) ([142ce42](142ce42)) ### Bug Fixes * Stopping engine not required before switching cluster ([#727](#727)) ([af675c1](af675c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prior to updating the cluster, if stopping the engine fails, it just logs a warning.
Is this change user facing?
NO
References (if applicable):