Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only forward APIC port on remote context. #1049

Merged
merged 3 commits into from Aug 3, 2023

Conversation

laurentluce
Copy link
Contributor

Description:

The CLI tried to forward the APIC port on local context. This change makes sure that this happens only on remote context.

Is this change user facing?

NO

References (if applicable):

Closes #1039

@laurentluce laurentluce requested a review from gbouv August 3, 2023 03:51
Copy link
Contributor

@gbouv gbouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with one suggestion

@laurentluce laurentluce enabled auto-merge (squash) August 3, 2023 15:24
@laurentluce laurentluce merged commit 7072b7b into main Aug 3, 2023
29 checks passed
@laurentluce laurentluce deleted the laurent/no_apic_forward_on_local_context branch August 3, 2023 19:02
h4ck3rk3y pushed a commit that referenced this pull request Aug 4, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.81.4](0.81.3...0.81.4)
(2023-08-03)


### Bug Fixes

* Only forward APIC port on remote context.
([#1049](#1049))
([7072b7b](7072b7b)),
closes [#1039](#1039)
* remove historical enclave names from auto complete
([#1059](#1059))
([e63fd88](e63fd88))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CLI should not try to forward the APIC port when on local context
2 participants