Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talk about @ imports in import_module so that people can pin versions #1255

Closed
h4ck3rk3y opened this issue Sep 7, 2023 · 2 comments · Fixed by #1263
Closed

talk about @ imports in import_module so that people can pin versions #1255

h4ck3rk3y opened this issue Sep 7, 2023 · 2 comments · Fixed by #1263
Assignees
@leeederek
Labels
docs

Comments

@h4ck3rk3y
Copy link
Contributor

Where did you see the issue in our documentation?

https://docs.kurtosis.com/starlark-reference/import-module/

Issue description

Solves the JustFarming issues
@h4ck3rk3y h4ck3rk3y added the docs label Sep 7, 2023
@h4ck3rk3y h4ck3rk3y mentioned this issue Sep 7, 2023
Closed
@leeederek
Copy link
Contributor

Thanks @h4ck3rk3y i'll work on this.

@tomknig
Copy link

tomknig commented Sep 7, 2023

Thanks for tracking this issue. I do agree that adding documentation around pinned versions will be helpful.
We've successfully implemented pinned versions in our project here: justfarming/contracts#3

@leeederek leeederek mentioned this issue Sep 7, 2023
Merged
leeederek added a commit that referenced this issue Sep 7, 2023
@leeederek
docs: add docs for pinning package versions with import_module() (#1263)
b286411 
## Description:
This PR adds a code example and a short blurb in our FAQ on how to pin
specific versions of packages when using the `import_module()` function
in starlark.

## Is this change user facing?
YES

## References (if applicable):
Fixes #1255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leeederek leeederek

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add docs for pinning package versions with import_module() kurtosis-tech/kurtosis
3 participants
@tomknig @h4ck3rk3y @leeederek