Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexer/frontend is treating arg as a string when it should be JSON #1479

Closed
mieubrisse opened this issue Oct 5, 2023 · 0 comments · Fixed by #1539
Closed

Indexer/frontend is treating arg as a string when it should be JSON #1479

mieubrisse opened this issue Oct 5, 2023 · 0 comments · Fixed by #1539
Assignees
Labels
bug Something isn't working bugbash critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend

Comments

@mieubrisse
Copy link
Member

What's your CLI version?

0.84.2

Description & steps to reproduce

The Ethereum package's args don't have the docstring, so they should be JSON. However, the frontend is displaying this as a string:

Screen Shot 2023-10-05 at 15 42 12

Desired behavior

Because there's no docstring, the arg should default to JSON.

What is the severity of this bug?

Critical; I am blocked and Kurtosis is unusable for me because of this bug.

What area of the product does this pertain to?

Frontend: the Graphical User Interface, including the Enclave Manager

@mieubrisse mieubrisse added the bug Something isn't working label Oct 5, 2023
@github-actions github-actions bot added critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend labels Oct 5, 2023
@tedim52 tedim52 added the bugbash label Oct 8, 2023
@adschwartz adschwartz self-assigned this Oct 12, 2023
adschwartz added a commit that referenced this issue Oct 12, 2023
## Description:
Fixing these bugs:
* Mishandling of the internal representation of JSON objects in the
package manager form fields
* Default data type for fields is now set to JSON
* Invalid json fields were not failing the validity checker on the
field. Fixed as well.

## Is this change user facing?
YES

## References (if applicable):
Closes #1501
Closes #1479
leoporoli pushed a commit that referenced this issue Oct 12, 2023
## Description:
Fixing these bugs:
* Mishandling of the internal representation of JSON objects in the
package manager form fields
* Default data type for fields is now set to JSON
* Invalid json fields were not failing the validity checker on the
field. Fixed as well.

## Is this change user facing?
YES

## References (if applicable):
Closes #1501
Closes #1479
adschwartz pushed a commit that referenced this issue Oct 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.5](0.84.4...0.84.5)
(2023-10-12)


### Features

* highlight the active cluster in kurtosis cluster ls
([#1514](#1514))
([67e0111](67e0111))
* local replace package dependency
([#1521](#1521))
([d5e3126](d5e3126))
* manage script return value
([#1546](#1546))
([a53508f](a53508f))


### Bug Fixes

* run package bug
([#1539](#1539))
([1f5380a](1f5380a)),
closes [#1501](#1501)
[#1479](#1479)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugbash critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants