Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run package bug #1539

Merged
merged 3 commits into from Oct 12, 2023
Merged

fix: run package bug #1539

merged 3 commits into from Oct 12, 2023

Conversation

adschwartz
Copy link
Contributor

@adschwartz adschwartz commented Oct 12, 2023

Description:

Fixing these bugs:

  • Mishandling of the internal representation of JSON objects in the package manager form fields
  • Default data type for fields is now set to JSON
  • Invalid json fields were not failing the validity checker on the field. Fixed as well.

Is this change user facing?

YES

References (if applicable):

Closes #1501
Closes #1479

Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending status checks

@tedim52 tedim52 changed the title Anders/fix runpackage bug fix: run package bug Oct 12, 2023
@adschwartz adschwartz merged commit 1f5380a into main Oct 12, 2023
36 of 38 checks passed
@adschwartz adschwartz deleted the anders/fix-runpackage-bug branch October 12, 2023 18:09
leoporoli pushed a commit that referenced this pull request Oct 12, 2023
## Description:
Fixing these bugs:
* Mishandling of the internal representation of JSON objects in the
package manager form fields
* Default data type for fields is now set to JSON
* Invalid json fields were not failing the validity checker on the
field. Fixed as well.

## Is this change user facing?
YES

## References (if applicable):
Closes #1501
Closes #1479
adschwartz pushed a commit that referenced this pull request Oct 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.5](0.84.4...0.84.5)
(2023-10-12)


### Features

* highlight the active cluster in kurtosis cluster ls
([#1514](#1514))
([67e0111](67e0111))
* local replace package dependency
([#1521](#1521))
([d5e3126](d5e3126))
* manage script return value
([#1546](#1546))
([a53508f](a53508f))


### Bug Fixes

* run package bug
([#1539](#1539))
([1f5380a](1f5380a)),
closes [#1501](#1501)
[#1479](#1479)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants